Change error message about low stock#17642
Merged
magento-engcom-team merged 2 commits intomagento:2.3-developfrom Aug 19, 2018
vkublytskyi:msi-e-msgs
Merged
Change error message about low stock#17642magento-engcom-team merged 2 commits intomagento:2.3-developfrom vkublytskyi:msi-e-msgs
magento-engcom-team merged 2 commits intomagento:2.3-developfrom
vkublytskyi:msi-e-msgs
Conversation
Contributor
|
Hi @vkublytskyi. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Contributor
|
Hi @vkublytskyi. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change error message about low stock from
We don\'t have as many "{product name}" as you requested.toThe requested qty is not available.Why this change is required?
MSI project introduces a new mechanism of inventory management for Magento 2. Now MSI and Magento Open Source have different error messages that may introduce difficulties for switching from current inventory management to MSI and complicate test suite.
Why core is fixed instead of MSI?
MSI implementation strongly follows SOLID principles. At the point where an error message is created no information about a product available. Any possible fixes will break encapsulation, introduce undesirable coupling and lead to performance degradation.
Change of messages in core has no cost and no significant impact on user experience